-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the detection of schema changes and add tests #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
schema-evolution-better-detection
branch
from
December 2, 2024 14:36
2282a95
to
5beaf8b
Compare
This works for now, but I am not extremely happy with the overall implementation at the moment. At some point there should be some refactoring of the whole detection system and script to make it easier to test and extend. |
andresailer
reviewed
Dec 2, 2024
andresailer
reviewed
Dec 2, 2024
andresailer
reviewed
Dec 2, 2024
tmadlener
changed the title
[WIP] Improve the detection of schema changes and add tests
Improve the detection of schema changes and add tests
Dec 2, 2024
@hegner anything speaking against solving this like this for now and then doing some refactoring later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
podio_schema_evolution.py
detects and reports onVectorMembers
,OneToOneRelations
andOneToManyRelations
ENDRELEASENOTES
Fixes #712
OneToOneRelations
OneToManyRelations