Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the detection of schema changes and add tests #715

Merged
merged 12 commits into from
Dec 17, 2024

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Dec 2, 2024

BEGINRELEASENOTES

  • Improve the schema changes that podio_schema_evolution.py detects and reports on
    • Addition / removal of VectorMembers, OneToOneRelations and OneToManyRelations
  • Make the script exit with a non-zero exit code in case an unsupported schema change is detected
  • Add a test setup and some tests for testing the schema evolution script and make sure it detects unsupported changes

ENDRELEASENOTES

Fixes #712

  • Implement detection of changes to OneToOneRelations
  • Implement detection of changes to OneToManyRelations

@tmadlener tmadlener force-pushed the schema-evolution-better-detection branch from 2282a95 to 5beaf8b Compare December 2, 2024 14:36
@tmadlener
Copy link
Collaborator Author

This works for now, but I am not extremely happy with the overall implementation at the moment. At some point there should be some refactoring of the whole detection system and script to make it easier to test and extend.

@tmadlener tmadlener requested a review from hegner December 2, 2024 14:38
@tmadlener tmadlener changed the title [WIP] Improve the detection of schema changes and add tests Improve the detection of schema changes and add tests Dec 2, 2024
@tmadlener
Copy link
Collaborator Author

@hegner anything speaking against solving this like this for now and then doing some refactoring later?

@tmadlener tmadlener merged commit ec61a51 into master Dec 17, 2024
18 checks passed
@tmadlener tmadlener deleted the schema-evolution-better-detection branch December 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema evolution check script does not detect changes in non-members
2 participants