Make accessing single elements in empty parameter vectors return an empty optional #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed during the meeting on Nov 5, we will be using an empty optional (as is the current state of this PR at the moment). |
tmadlener
force-pushed
the
params-empty-vec-access
branch
from
40014d0 to
70f63ed
Compare
Otherwise we run into a read out of bounds in case the parameter is stored, but with an empty vector value. E.g. from setting it with a vector that comes from an external source which is empty.
tmadlener
force-pushed
the
params-empty-vec-access
branch
from
70f63ed to
6c7c090
Compare
jmcarcell
added a commit
to jmcarcell/podio
that referenced
this pull request
Nov 18, 2024
…mpty optional (AIDASoft#693) * Add simple reproducer of previous issue as test * Return an empty optional in case there are no values Otherwise we run into a read out of bounds in case the parameter is stored, but with an empty vector value. E.g. from setting it with a vector that comes from an external source which is empty. * Add test for python bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
GenericParameterswhere trying to access a single element of a parameter that was stored as an empty vector resulted in a crash. Instead make this return an empty optional now.ENDRELEASENOTES
@dirkzerwas this is the fix for the issue in our email discussion.
This seems to be the most reasonable thing to do. The other option would be to return an empty / default constructed value in this case. However, since we introduced the
std::optionalreturn type for avoiding exactly that (see #580), I don't think that makes a lot of sense and would make the API inconsistent again.