Rework the I/O handling for relations #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
tmadlener
commented
Sep 11, 2024
tmadlener
commented
Sep 13, 2024
tmadlener
commented
Sep 13, 2024
tmadlener
force-pushed
the
relation-io-rework
branch
2 times, most recently
from
af032d8 to
9b7f8fa
Compare
This is work that has become necessary for making links work that contain interface types. - Remove differences in handling of interface vs regular types in the jinja2 templates and lift it into a separate function that dispatches depending on the type of the relation - Make the interfaced_types type member publicly available for interface types - Add type helpers to detect whether a type is an interface type
tmadlener
force-pushed
the
relation-io-rework
branch
from
9b7f8fa to
7e9933e
Compare
hegner
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
interfaced_typesmember type for interface types and add a type helper to check whether a type is an interface typeENDRELEASENOTES
This has fallen out as a relatively isolated change in #257, where this has become necessary to be able to handle links that contain an interface type.