-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass an argument by const reference instead of value and other minor fixes #633
Conversation
Looks like CERNs infrastructure is slightly overwhelmed, CI is failing because we cannot get cvmfs or because fetching test data is failing. |
Another minor fix that could be added: podio/python/templates/macros/implementations.jinja2 Lines 184 to 189 in d12f4df
|
Can you pick up the changes from #634 (i.e. merge / rebase onto latest master)? I think that should fix the remaining CI issues that we see. |
Done |
BEGINRELEASENOTES
nullptr
before deleting a (possiblynullptr
) pointerif - else
check and use implicit conversion of pointer to boolENDRELEASENOTES