Make schema_model a mandatory field in datamodel definitions #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Feb 12, 2024
tmadlener
changed the title
This was referenced Feb 12, 2024
hegner
approved these changes
Feb 13, 2024
kodiakhq bot
pushed a commit
to acts-project/acts
that referenced
this pull request
Apr 20, 2024
Since AIDASoft/podio#556 the mandatory schema_version does not just generate a warning anymore, but fails with an error. This will prevent CMake from configuring correctly with newer podio versions, in particular version 1 coming up. This PR adds a schema_version of 1 to edm.yml.
EleniXoch
pushed a commit
to EleniXoch/acts
that referenced
this pull request
May 6, 2024
Since AIDASoft/podio#556 the mandatory schema_version does not just generate a warning anymore, but fails with an error. This will prevent CMake from configuring correctly with newer podio versions, in particular version 1 coming up. This PR adds a schema_version of 1 to edm.yml.
asalzburger
pushed a commit
to asalzburger/acts
that referenced
this pull request
May 21, 2024
Since AIDASoft/podio#556 the mandatory schema_version does not just generate a warning anymore, but fails with an error. This will prevent CMake from configuring correctly with newer podio versions, in particular version 1 coming up. This PR adds a schema_version of 1 to edm.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
When going through the paths in the errors this is the first one when configuring which is annoying