Generate mutable reference getters for all members #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
mutable-refs
branch
from
b248022 to
74634eb
Compare
|
@tmadlener - add the tests and I can accept :-) |
Previously this was only generated for non-builtin (i.e non-trivial) members. Additionally, deprecate the API that does not respect the getSyntax option.
tmadlener
force-pushed
the
mutable-refs
branch
from
74634eb to
209e08a
Compare
|
Done. |
This was referenced Mar 14, 2024
7 tasks
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Mar 27, 2024
### Briefly, what does this PR introduce?
This PR changes the direct member access to a getter to avoid a compiler
warning:
```
/home/wdconinc/git/EICrecon/.worktree/pfrich-digitization/src/algorithms/pid/ParticlesWithPID.cc:145:44: warning: 'referencePoint' is deprecated: use getReferencePoint instead [-Wdeprecated-declarations]
145 | auto referencePoint = rec_part.referencePoint();
| ^
/opt/local/include/edm4eic/MutableReconstructedParticle.h:142:5: note: 'referencePoint' has been explicitly marked deprecated here
142 | [[deprecated("use getReferencePoint instead")]]
| ^
```
This applies since AIDASoft/podio#553.
### What kind of change does this PR introduce?
- [x] Bug fix (issue: deprecated )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __
### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators
### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.
### Does this PR change default behavior?
No.
ajentsch
pushed a commit
to eic/EICrecon
that referenced
this pull request
May 20, 2024
### Briefly, what does this PR introduce?
This PR changes the direct member access to a getter to avoid a compiler
warning:
```
/home/wdconinc/git/EICrecon/.worktree/pfrich-digitization/src/algorithms/pid/ParticlesWithPID.cc:145:44: warning: 'referencePoint' is deprecated: use getReferencePoint instead [-Wdeprecated-declarations]
145 | auto referencePoint = rec_part.referencePoint();
| ^
/opt/local/include/edm4eic/MutableReconstructedParticle.h:142:5: note: 'referencePoint' has been explicitly marked deprecated here
142 | [[deprecated("use getReferencePoint instead")]]
| ^
```
This applies since AIDASoft/podio#553.
### What kind of change does this PR introduce?
- [x] Bug fix (issue: deprecated )
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __
### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators
### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.
### Does this PR change default behavior?
No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
MutabletypesgetSyntaxoption.ENDRELEASENOTES
@paulgessinger this should be more or less what we discussed today. A minor drawback that I just realized is that for the
constversions of these getters we return by value for builtin types rather than byconst&(mainly premature optimization I would say). In any case, it shouldn't really matter for you, and I think I am OK with that small inconsistency.