Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool to transform between TTrees and RNTuples #541

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Add tool to transform between TTrees and RNTuples

ENDRELEASENOTES

Installed only when compiling with RNTuple enabled

@jmcarcell jmcarcell force-pushed the TTree-to-RNTuple branch 2 times, most recently from 002f78d to 6de122c Compare January 17, 2024 12:12
@tmadlener
Copy link
Collaborator

Can you rebase this to pick up #540 for CI?

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and simple enough to me. It also looks like this should copy over everything and just recreate metadata on the fly as necessary. I am not sure whether we need a dedicated test for the whole thing, as all the pieces are in principle already tested on their own. Unless, there are any concerns, I would merge this as is later today.

@jmcarcell
Copy link
Member Author

Yeah they are tested independently, at least I used this in the two directions and it worked. When there is an interface maybe it can be changed so there is automatic detection of the direction but it's not that important

@tmadlener
Copy link
Collaborator

As far as I can see this can handle #543 transparently, right?

@jmcarcell
Copy link
Member Author

Yes, in python we already had that name, so another reason to change it from the original one

@tmadlener tmadlener merged commit da7b0d2 into AIDASoft:master Jan 25, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants