Fix legacy tests

[jmcarcell]

BEGINRELEASENOTES

• Fix legacy tests; an extra argument was being passed and default in the .cpp file example_frame.root was being used which (almost) always exists (because there is a another test creating it) so it was hard to notice.
  ENDRELEASENOTES

Maybe this default should be changed so as to be more explicit so this can't happen but it would make the implementation in the CMakeLists in root_io a bit less clean.

[tmadlener]

Good catch. Not sure I understand the diff though or why it worked before. Previously it got 3 arguments, so how did it end up reading the default example_frame.root?

[jmcarcell]

It's the default value and it's changed based on the number of arguments:
https://github.com/AIDASoft/podio/blob/master/tests/root_io/read_frame_root.cpp#L10
And since there is another test creating it with the current version of podio, reading that will never fail. I only noticed it because when running the tests in parallel it didn't work which makes no sense; it was reading the file that was just being created in all the legacy tests and that wasn't working.

[tmadlener]

Ah, its a argc == 2. Then the fix that would at least have caught this issue would be to also have an additional check for > 2 in the executable, right?

[jmcarcell]

Yep, I added the check

[tmadlener]

Thanks.

[tmadlener]

closing and re-opening to trigger actions, which seem to have gone missing somehow for the last commit.