Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema evolution check script does not detect changes in non-members #712

Closed
tmadlener opened this issue Nov 25, 2024 · 1 comment · Fixed by #715
Closed

Schema evolution check script does not detect changes in non-members #712

tmadlener opened this issue Nov 25, 2024 · 1 comment · Fixed by #715
Labels

Comments

@tmadlener
Copy link
Collaborator

The current version of the script that checks for impossible schema changes does not detect changes to VectorMembers, OneToOneRelations and OneToManyRelations. Instead it just let's schemas with these changes pass without warning or error. The schema evolution mechanism can in principle handle these, but will need some manual intervention obviously. As a first step, we should at least detect these changes and mark them as impossible, instead of letting users run into runtime issues when doing changes like these and trying to read old files.

@tmadlener tmadlener added the bug label Nov 25, 2024
@tmadlener
Copy link
Collaborator Author

This would be necessary to e.g. handle key4hep/EDM4hep#382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant