Rename OfferIssuerId
#720
Merged
Rename OfferIssuerId
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OfferIssuerId` was previously named `OfferNodeId`, but its usage changed when it was renamed: it doesn't necessarily match a lightning `node_id` and can instead be a completely unrelated public key. It can now be included in combination with blinded paths: when that happens, the blinded paths must be used in priority to reach the node as the `issuer_id` may not match a network `node_id` at all (or may even match an unrelated node).
thomash-acinq
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OfferIssuerIdwas previously namedOfferNodeId, but its usage changed when it was renamed: it doesn't necessarily match a lightningnode_idand can instead be a completely unrelated public key. Note that we should probably also rename this ineclairif it hasn't already been done.It can now be included in combination with blinded paths: when that happens, the blinded paths must be used in priority to reach the node as the
issuer_idmay not match a networknode_idat all (or may even match an unrelated node).I'm clarifying this and getting rid of
contact_node_idsbecause for #719 I would like to use ascontact_node_id:issuer_idif includedblinded_node_idof the first pathThis makes more sense for wallets that generate multiple offers with different blinded paths each time, but keep the same
issuer_id.