Remove deprecated serialization format and fields #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
remove-old-serialization
branch
from
1a8b468 to
ab7fdd4
Compare
t-bast
force-pushed
the
remove-old-serialization
branch
2 times, most recently
from
d53ef40 to
0f7796a
Compare
t-bast
force-pushed
the
remove-old-serialization
branch
from
0f7796a to
44d5d86
Compare
t-bast
force-pushed
the
remove-old-serialization
branch
2 times, most recently
from
ce6ecf4 to
290636e
Compare
The v4 serialization format was released in July 2023 with better support for backwards-compatibility: the v2 and v3 formats used kotlin's serialization, which prevents us from removing legacy classes and requires additional code whenever we change something in the channel state. Users who haven't migrated their data to the v4 format will not be able to deserialize their channel data: they will need to use a previous version of the app to read their old channel data, write it to the v4 format and then upgrade to the latest version. We also remove a bunch of fields/options that were deprecated a while ago: - legacy channel funding states - unused legacy features - legacy private key generation - legacy node events
t-bast
force-pushed
the
remove-old-serialization
branch
from
290636e to
9e57421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do some clean-up of deprecated fields, classes and serialization formats. This is a breaking change for users who have never launched the app since the v1.5.0 release (from july 2023). It is not possible to upgrade directly from a version < 1.5.0, an intermediate update will be required.