Send commit sigs for alternative feerates #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
reviewed
Oct 18, 2023
src/commonMain/kotlin/fr/acinq/lightning/channel/states/Channel.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/fr/acinq/lightning/channel/Commitments.kt
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Oct 19, 2023
|
I rebased on master in branch custom-feerate-commit-sig-pm. |
Test successful, I even RBFed the commit tx with higher custom commit sigs. |
pm47
requested changes
Nov 2, 2023
When the commitment transaction doesn't contain any HTLC, we send additional signatures for alternative feerates. This lets the wallet provider force-close with a more interesting feerate when the wallet user disappears without closing their channels.
This is useful for the initial funding transaction and mostly for splices.
t-bast
force-pushed
the
custom-feerate-commit-sig
branch
from
8032630 to
fe9da80
Compare
|
Rebased to fix import issue. |
pm47
approved these changes
Nov 2, 2023
|
Do we want to extend this to also support sending htlc sigs when splices contain htlcs? or just skip sending these tlvs when htlc's are present? |
|
We're only sending those additional sigs when the commitment is empty (no HTLCs), so there's nothing to do in the case where it's a splice with HTLCs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the commitment transaction doesn't contain any HTLC, we send additional signatures for alternative feerates. This lets the wallet provider force-close with a more interesting feerate when the wallet user disappears without closing their channels.