Refactor peer connection establishment #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Oct 17, 2023
This commits uses the new Peer connection timeouts added in ACINQ/lightning-kmp#541 Note that the timeouts depend on the number of consecutive failed connection attempts, and whether TOR is enabled or not.
Use the same pattern as the `ElectrumClient`, with an explicit job and timeouts. The `connect` function now suspends, which makes it easier to handle from the caller's point of view. Fixes #531
t-bast
force-pushed
the
peer-connection-timeout
branch
from
2746ddd to
ff7a089
Compare
dpad85
approved these changes
Nov 9, 2023
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Nov 16, 2023
A dynamic timeout is used when connecting to Peer/Electrum. Note that the timeouts depend on the number of consecutive failed connection attempts, and whether TOR is enabled or not. This commits uses the new Peer connection timeouts added in ACINQ/lightning-kmp#541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same pattern as the
ElectrumClient, with an explicit job and timeouts. Theconnectfunction now suspends, which makes it easier to handle from the caller's point of view.We don't have an easy way of unit testing that in
lightning-kmp, so this will deserve some e2e tests.Fixes #531