Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed swap-in utxos refund delay #540

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Sep 26, 2023

Utxos used for swap-in have an expiry: after a delay the user can spend them unilaterally, which makes them dangerous to accept by the swap provider when we get close to that expiry. We expose these limits so that applications can tell their users to finalize swaps before reaching the expiry, otherwise they'll have to wait before unlocking them.

Fixes #534

Utxos used for swap-in have an expiry: after a delay the user can spend
them unilaterally, which makes them dangerous to accept by the swap
provider when we get close to that expiry. We expose these limits so
that applications can tell their users to finalize swaps before reaching
the expiry, otherwise they'll have to wait before unlocking them.

Fixes #534
@t-bast t-bast requested a review from dpad85 September 26, 2023 12:29
Copy link
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏
Made a prototype on Android and we have all the info needed.

@t-bast t-bast merged commit c01a4ac into master Sep 27, 2023
@t-bast t-bast deleted the expose-deeply-confirmed-timeout branch September 27, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose deeply confirmed utxos grace period in WalletWithConfirmations
2 participants