Use TxId and TxHash objects
#524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
use-bitcoin-kmp-txid
branch
from
d3f8384 to
ae73360
Compare
This helps disambiguate when each is used. Even though confusingly, Electrum calls its field `tx_hash` while actually returning the `txid`.
t-bast
force-pushed
the
use-bitcoin-kmp-txid
branch
from
ae73360 to
4235964
Compare
sstone
previously approved these changes
Nov 23, 2023
pm47
previously approved these changes
Nov 28, 2023
src/commonMain/kotlin/fr/acinq/lightning/serialization/v3/ChannelState.kt
Outdated
Show resolved
Hide resolved
pm47
approved these changes
Nov 28, 2023
sstone
approved these changes
Nov 28, 2023
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Nov 30, 2023
See for details: - ACINQ/bitcoin-kmp#90 - ACINQ/lightning-kmp#524 Transaction ids are still stored as byte arrays in the database (use txId.value to get the raw data), but we should use the correct types whenever possible. Use toString() to get the txid as an hexa string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps disambiguate when each is used. Even though confusingly, Electrum calls its field
tx_hashwhile actually returning thetxid.This is mostly a trivial replacement from
ByteVector32toTxIdand removing a lot of calls toreversed(). The only subtle parts are in thewirepackage, where we now only exposeTxIdbut in most cases actually encode/decode atx_hash.