FIX eclair-cli error code in case of HTTP problem

[pgrange]

Last command of eclair-cli is a curl piped to jq. In case of an error with the curl command (for instance, eclair service is not running) the error code is swallowed by the pipe which will return the exit code of the last command of the pipe (here, jq).

Setting pipefail ensures that the error code of curl is preserved in case of HTTP issue.

This can come handy, for instance, to check that eclair is not ok:

if eclair-cli getinfo
then
  echo eclair is answering
else
  echo problem communicating with eclair
fi

[t-bast]

Thanks! @sstone can you take a look at this?

[codecov-commenter]

Codecov Report

Merging #2798 (6b76fa5) into master (be4ed3c) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2798      +/-   ##
==========================================
+ Coverage   85.86%   85.87%   +0.01%     
==========================================
  Files         216      216              
  Lines       18177    18177              
  Branches      786      786              
==========================================
+ Hits        15607    15609       +2     
+ Misses       2570     2568       -2     

see 5 files with indirect coverage changes

[sstone]

Thanks! tested on ubuntu and AWS linux (but it should not break any working setup since we specify #!/bin/bash at the beginning of eclair-cli), and it has no impact on our nitro tools.