Don't rebroadcast channel updates from update_fail_htlc
#2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we receive a `channel_update` in `update_fail_htlc`, we should take it into account to exclude channels or correctly retry with updated fees, but we shouldn't apply it to our routing table. If we did, that could be exploited to deanonymize our payments. It shouldn't be necessary anyway, as honest nodes should broadcast those `channel_update`s publicly, so we would receive them through the normal gossip mechanism. Fixes #2767
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2775 +/- ##
==========================================
- Coverage 85.83% 85.82% -0.02%
==========================================
Files 216 216
Lines 18129 18128 -1
Branches 775 773 -2
==========================================
- Hits 15561 15558 -3
- Misses 2568 2570 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive a
channel_updateinupdate_fail_htlc, we should take it into account to exclude channels or correctly retry with updated fees, but we shouldn't apply it to our routing table.If we did, that could be exploited to deanonymize our payments. It shouldn't be necessary anyway, as honest nodes should broadcast those
channel_updates publicly, so we would receive them through the normal gossip mechanism.Fixes #2767