Abort interactive-tx during funding #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we abort the interactive-tx protocol while we're waiting for bitcoind to fund the transaction, we must avoid sending an obsolete `tx_add_input` for the funded transaction. There is a check in `Channel.scala` to only send an outgoing interactive-tx message if we have an active interactive-tx session, but this isn't sufficient in the following scenario: - we disconnect and thus abort the interactive-tx session while bitcoind is funding - we reconnect and restart another interactive-tx session - bitcoind responds for the first interactive-tx session In that scenario we would mix `tx_add_input` from the old and the new interactive-tx session, which leads to a duplicate `serial_id`.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2769 +/- ##
==========================================
+ Coverage 85.84% 85.85% +0.01%
==========================================
Files 216 216
Lines 18102 18095 -7
Branches 762 777 +15
==========================================
- Hits 15540 15536 -4
+ Misses 2562 2559 -3
|
This lets us fix the race between the `Abort` sent from the `Channel` to the `InteractiveTxBuilder` and the funding result sent from `bitcoind` to the `InteractiveTxBuilder`.
pm47
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we abort the interactive-tx protocol while we're waiting for bitcoind to fund the transaction, we must avoid sending an obsolete
tx_add_inputfor the funded transaction. There is a check inChannel.scalato only send an outgoing interactive-tx message if we have an active interactive-tx session, but this isn't sufficient in the following scenario:In that scenario we would mix
tx_add_inputfrom the old and the new interactive-tx session, which leads to a duplicateserial_id.