Add support for sciddir_or_pubkey

[thomash-acinq]

Offers (lightning/bolts#798) allow nodes to be identified using either the public key or a pair channel id and direction. The goal is to save bytes as channel id and direction only use 9 bytes instead of 33 for a public key.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (12adf87) to head (0500259).
Report is 101 commits behind head on master.

Files with missing lines	Patch %	Lines
...c/main/scala/fr/acinq/eclair/message/Postman.scala	89.47%	2 Missing ⚠️
...la/fr/acinq/eclair/payment/send/OfferPayment.scala	91.66%	2 Missing ⚠️
...r/acinq/eclair/payment/send/PaymentInitiator.scala	33.33%	2 Missing ⚠️
...scala/fr/acinq/eclair/payment/send/Autoprobe.scala	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
+ Coverage   85.82%   85.85%   +0.03%     
==========================================
  Files         216      216              
  Lines       18126    18158      +32     
  Branches      771      760      -11     
==========================================
+ Hits        15556    15590      +34     
+ Misses       2570     2568       -2     

Files with missing lines	Coverage Δ
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala	55.69% <100.00%> (ø)
...n/scala/fr/acinq/eclair/json/JsonSerializers.scala	96.42% <ø> (ø)
.../scala/fr/acinq/eclair/message/OnionMessages.scala	80.00% <100.00%> (+0.28%)	⬆️
.../scala/fr/acinq/eclair/payment/Bolt12Invoice.scala	97.50% <100.00%> (ø)
...a/fr/acinq/eclair/payment/offer/OfferManager.scala	92.59% <100.00%> (ø)
...cinq/eclair/payment/receive/MultiPartHandler.scala	93.33% <ø> (ø)
...scala/fr/acinq/eclair/payment/send/Recipient.scala	98.52% <100.00%> (ø)
...src/main/scala/fr/acinq/eclair/router/Router.scala	94.39% <100.00%> (-0.39%)	⬇️
...la/fr/acinq/eclair/wire/protocol/OfferCodecs.scala	100.00% <100.00%> (ø)
...ala/fr/acinq/eclair/wire/protocol/OfferTypes.scala	96.36% <100.00%> (ø)
... and 4 more

... and 12 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[t-bast]

Can you rebase this PR before I start reviewing it?

[thomash-acinq]

Rebased

[t-bast]

Looks good to me, this is now quite clean! I've made two follow-up commits in #2776 to do some renaming and refactoring, nothing major but I think it slightly improves this.

[thomash-acinq]

I've added your commits, I've just changed two comments which I thought could be misleading.

[t-bast]

👍