-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use psbt to fund and sign transactions #1876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
use-psbt
branch
3 times, most recently
from
July 22, 2021 17:20
17032dc
to
f9478c1
Compare
sstone
force-pushed
the
use-psbt
branch
3 times, most recently
from
August 16, 2021 16:20
cb31307
to
44dbaf3
Compare
sstone
force-pushed
the
use-psbt
branch
7 times, most recently
from
August 24, 2021 07:03
e36d2e4
to
ad60adf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1876 +/- ##
==========================================
- Coverage 87.65% 87.63% -0.03%
==========================================
Files 158 158
Lines 12406 12467 +61
Branches 515 525 +10
==========================================
+ Hits 10875 10925 +50
- Misses 1531 1542 +11
|
While reading this PR, I realized that:
|
sstone
force-pushed
the
use-psbt
branch
2 times, most recently
from
September 13, 2021 08:21
400e085
to
7226a66
Compare
sstone
force-pushed
the
use-psbt
branch
3 times, most recently
from
September 22, 2021 07:55
b4eb3cc
to
b8a5a6c
Compare
…bitcoin core We add: - the bip32 path for our local funding pubkey, without the first 2 items (that are based on which chain we're on) - a dummy 1/2/3/4 path for the remote funding pubkey
This is used to fund PSBTs.
Superseded by #2120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.