Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Woot mixin for proper entity cleanup #552

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

jchung01
Copy link
Contributor

@jchung01 jchung01 commented Sep 5, 2024

Fixes an issue where Woot's simulation dimension (Tartarus) would not cleanup some item drops and any entity summons from the simulated mob's death. Because the dimension has no persistent chunks, it would be in a weird state where the dimension stays loaded with a lot of non-ticking entities, which can accumulate and cause server lag. Maintains a ticket to forceload the simulation chunk when needed, similar to what modern versions of the mod do.

Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Addition of Woot Environment Control
    Added a new functionality to control the way the 'Woot' mod operates. This includes a "Cleanup Simulated Kills" option that can be toggled on or off based on the user's preference.

  • Woot Mod Dependency
    Our project now relies on the Woot mod, which means you need to have this mod installed as well for our project code to run smoothly.

  • Configuration Enhancement
    We updated our configuration with a dedicated category for the Woot mod. This new setup will make using Woot-related functionalities more user-friendly and intuitive.

  • Mixins Addition
    Several Mixins have been used to modify certain aspects of the Woot mod. These changes are made seamlessly through our project, enhancing the overall Woot mod behavior.

  • New Files
    Several new files related to the Woot mod were added to the project. These files allow customization and provide functionalities related to the Woot mod.

  • Language Support
    Added a new translation in English for the newly added Woot category to make it more understandable to our English-speaking users.

  • Mixin Configuration
    Injected a new mix-in configuration for the Woot mod, helping us merge our changes with the original Woot mod more efficiently.

  • Correction
    Fixed a small typo in the Readme file to ensure the information there is accurate and helpful.

@ACGaming ACGaming merged commit d006e13 into ACGaming:main Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants