Improve Emojicord's emoji context calculation #539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emojicord calls
Thread.currentThread().getStackTrace()
to calculate the emoji context whenever text gets rendered. For example, in the hotkey menu, there is a huge FPS drop. Also, see Team-Fruit/Emojicord#23.This PR fixes this issue by setting a flag at the start of
GuiChat#drawScreen
andGuiNewChat#drawChat
which eliminates the need to check the stack trace.