Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Cabbage not dropping the correct items in some situations #442

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • overrides the damageDropped method to return the erebus food ordinal instead of 0.
  • injects and directs the outdated getDrops method (no List input) to the current getDrops method.
  • defaults to true.
  • this should simply restore the drop logic to that of all crops, just dropping the correct cabbage items.

this should fix mods that only use the modern getDrops method for various reasons (eg Agricraft, right click harvest mods, Roots Harvest Spell) dropping nothing/the wrong item.

@ACGaming ACGaming merged commit 380c0e7 into ACGaming:main Apr 18, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the cabbage branch April 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants