Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Mixin config files and obsolete mod logic into maps #436

Merged
merged 10 commits into from
Apr 12, 2024

Conversation

WaitingIdly
Copy link
Contributor

changes in this PR:

  • converts the current pattern of "add mixin file to list in one function, then add mixin file & option to switch statement in different function" into "add mixin file and option to map". this has multiple improvements:
    • dont have to write the same config name twice
    • easier to determine where to add the config for a map compared to an if statement
    • fixes a(t least one) mixin having the incorrect name and thus always being active
  • does a similar thing to obsolete mods
  • because you can obtain the mod name if it is installed and you have the modid, and the name is only displayed if the modid is enabled, replaced the explicit mod name with a programmatic version.

i believe these changes are desirable because it improves readability, maintainability, and decreases duplication.

@ACGaming ACGaming merged commit 1dffe37 into ACGaming:main Apr 12, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the mixin-and-obsolete-mod-simplified branch April 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants