Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent keybinds from overflowing left side of GUI #429

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

WaitingIdly
Copy link
Contributor

@WaitingIdly WaitingIdly commented Apr 9, 2024

always indent the keybind name slightly in from the page border. uses 5 because 20, as in the obsolete mod, seemed unneeded and too much indentation on small screens set to large GUI.
option is true by default
marks keydescfix as obsolete
as discussed in #57

Copy link

what-the-diff bot commented Apr 9, 2024

PR Summary

  • Introduction of new configuration option
    A new option called utPreventKeybindingEntryOverflow is added to UTConfigTweaks.MiscCategory. This setting allows users to control keybinding entry overflow settings.

  • Inclusion of mixin configuration in UTLoadingPlugin
    A new mixin configuration file, "mixins.tweaks.misc.gui.keybindlistentry.json" has been added to the UTLoadingPlugin. This update will enhance the plugin's functionality.

  • Creation of a new class for keybinding list entry rendering
    A new class UTKeyEntryMixin has been introduced. This is specifically designed to handle the task of displaying keybinding list entries, promising more efficiency in the process.

  • Compatibility check added for keydescfix
    In the UTObsoleteModsHandler, a compatibility check for the module keydescfix has now been added. This check uses the freshly added config option utPreventKeybindingEntryOverflow, thus ensuring better interaction between different modules.

  • Addition of a new mixin configuration file
    A new mixin configuration file mixins.tweaks.misc.gui.keybindlistentry.json has been added. This further broadens the functionality and configurability of our systems.

@ACGaming ACGaming merged commit 84add0b into ACGaming:main Apr 9, 2024
1 check passed
@WaitingIdly WaitingIdly deleted the long-keybind-name branch April 9, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants