Fix memory leaks for CB Multipart, MrTJPCore, Thaumic Wonders #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…weaks into memory-leaks
jchung01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the memory leaks for CB Multipart, MrTJPCore mentioned in #253 through mixins instead. The mods are in Scala but I found I can change their maps to use UUIDs instead of player instances because of a) type erasure and b) the converted bytecode works with
Objects. Idea taken from GTNH fork of MrTJPCore.Also implements the memory leak fix daedalus4096/ThaumicWonders#71 by @2302479492 as a mixin.
This should also update the README for all the PRs I did since last release.