Fix file name of swa checkpoints #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good spotting thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a the file name given to the checkpoint after the very first swa epoch.
Currently, swa is started in
train.pywhenepoch == swa_start, but the checkpoint file name only adds "swa" to the file name whenepoch > swa_start.This leads to a problem, when the first swa epoch has the lowest loss of all validated swa epochs. The checkpoint is saved under the wrong name, never overwritten and, at the end of the training, this checkpoint is saved as the best non-swa checkpoint (if the loss is lower then for any stage-one checkpoint), whereas the swa checkpoint is not found and an error is thrown.