Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a function to detect and correct for leap years #49

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Added a function to detect and correct for leap years #49

merged 3 commits into from
Jun 26, 2024

Conversation

physprop
Copy link
Collaborator

Directly fixes issue #37. Detects if its a leap year, and the applies the appropriate offset.

@physprop physprop requested a review from A-c0rN as a code owner June 26, 2024 09:10
@physprop physprop added the bug Something isn't working label Jun 26, 2024
@physprop physprop linked an issue Jun 26, 2024 that may be closed by this pull request
ASMARA says recently issued alert is very expired #37
Closed
A-c0rN
A-c0rN approved these changes Jun 26, 2024
View reviewed changes
Copy link
Owner

@A-c0rN A-c0rN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! one change needed and it should be good to ship.

asmara.py Outdated Show resolved Hide resolved
asmara.py Outdated Show resolved Hide resolved
@physprop
Copy link
Collaborator Author

Made the requested changes.

@physprop physprop merged commit 095791a into A-c0rN:main Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-c0rN A-c0rN A-c0rN approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASMARA says recently issued alert is very expired
2 participants
@physprop @A-c0rN