-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contribution Tutorial #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-c0rN
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One thing I would suggest;
"Include in-depth documentation on changes both in the commits and in the pull requests"
On it! |
A-c0rN
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A-c0rN
added a commit
that referenced
this pull request
Jan 28, 2024
* Fix Samedec bug When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then. Changed the string to check for 0.1.X, instead of 0.2.X, meaning that anything greater than V1 will work. Needs compatibility checking with V3. * Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md --------- Co-authored-by: Reggie Torres <[email protected]>
A-c0rN
added a commit
that referenced
this pull request
Feb 3, 2024
* Fix Samedec bug When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then. Changed the string to check for 0.1.X, instead of 0.2.X, meaning that anything greater than V1 will work. Needs compatibility checking with V3. * Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md --------- Co-authored-by: Reggie Torres <[email protected]>
A-c0rN
added a commit
that referenced
this pull request
Feb 3, 2024
* Fix Samedec bug When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then. Changed the string to check for 0.1.X, instead of 0.2.X, meaning that anything greater than V1 will work. Needs compatibility checking with V3. * Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md --------- Co-authored-by: Reggie Torres <[email protected]>
A-c0rN
added a commit
that referenced
this pull request
Feb 3, 2024
* Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md --------- Co-authored-by: Reggie Torres <[email protected]>
A-c0rN
added a commit
that referenced
this pull request
Feb 3, 2024
* Fix Samedec bug When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then. Changed the string to check for 0.1.X, instead of 0.2.X, meaning that anything greater than V1 will work. Needs compatibility checking with V3. * Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md * Added some logos (#22) Co-authored-by: Skylar Gray <[email protected]> --------- Co-authored-by: Reggie Torres <[email protected]> Co-authored-by: Skylar Gray <[email protected]> Co-authored-by: Skylar Gray <[email protected]>
A-c0rN
added a commit
that referenced
this pull request
Feb 3, 2024
* Create Runner (#6) * Create Runner This is Github runner that will be used for testing when ready. * Update and rename python-app.yml to main_runner.yml Added Flake8 as a dependency for the runner Renamed runner * Fix Flake8 execution Let's get it right this time, hopefully. * Flake8 is being annoying. Come on man, just work please. * Create CODEOWNERS Actually allow me to do checks properly * Add Contribution Tutorial (#12) * Add Contribution Tutorial * Update CONTRIBUTING.md * Added some logos (#22) Co-authored-by: Skylar Gray <[email protected]> --------- Co-authored-by: Reggie Torres <[email protected]> Co-authored-by: Skylar Gray <[email protected]> Co-authored-by: Skylar Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a (neat) little CONTRIBUTING.md more like How 2 Contribute 4 Dummies, Check it out!