Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contribution Tutorial #12

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Add Contribution Tutorial #12

merged 2 commits into from
Jan 28, 2024

Conversation

reggietorres
Copy link
Contributor

I made a (neat) little CONTRIBUTING.md more like How 2 Contribute 4 Dummies, Check it out!

@reggietorres reggietorres requested a review from A-c0rN as a code owner January 25, 2024 19:54
Copy link
Owner

@A-c0rN A-c0rN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing I would suggest;
"Include in-depth documentation on changes both in the commits and in the pull requests"

@reggietorres
Copy link
Contributor Author

On it!

Copy link
Owner

@A-c0rN A-c0rN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@A-c0rN A-c0rN merged commit 57a1add into A-c0rN:main Jan 28, 2024
1 check passed
A-c0rN added a commit that referenced this pull request Jan 28, 2024
* Fix Samedec bug

When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then.

Changed the string to check for 0.1.X, instead of 0.2.X, meaning that
anything greater than V1 will work.

Needs compatibility checking with V3.

* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

---------

Co-authored-by: Reggie Torres <[email protected]>
A-c0rN added a commit that referenced this pull request Feb 3, 2024
* Fix Samedec bug

When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then.

Changed the string to check for 0.1.X, instead of 0.2.X, meaning that
anything greater than V1 will work.

Needs compatibility checking with V3.

* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

---------

Co-authored-by: Reggie Torres <[email protected]>
A-c0rN added a commit that referenced this pull request Feb 3, 2024
* Fix Samedec bug

When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then.

Changed the string to check for 0.1.X, instead of 0.2.X, meaning that
anything greater than V1 will work.

Needs compatibility checking with V3.

* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

---------

Co-authored-by: Reggie Torres <[email protected]>
A-c0rN added a commit that referenced this pull request Feb 3, 2024
* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

---------

Co-authored-by: Reggie Torres <[email protected]>
A-c0rN added a commit that referenced this pull request Feb 3, 2024
* Fix Samedec bug

When this was written, SAMEDEC development was slow and on 0.2.3, and we didn't estimate a 3.0 launch then.

Changed the string to check for 0.1.X, instead of 0.2.X, meaning that
anything greater than V1 will work.

Needs compatibility checking with V3.

* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

* Added some logos (#22)

Co-authored-by: Skylar Gray <[email protected]>

---------

Co-authored-by: Reggie Torres <[email protected]>
Co-authored-by: Skylar Gray <[email protected]>
Co-authored-by: Skylar Gray <[email protected]>
A-c0rN added a commit that referenced this pull request Feb 3, 2024
* Create Runner (#6)

* Create Runner

This is Github runner that will be used for testing when ready.

* Update and rename python-app.yml to main_runner.yml

Added Flake8 as a dependency for the runner

Renamed runner

* Fix Flake8 execution

Let's get it right this time, hopefully.

* Flake8 is being annoying.

Come on man, just work please.

* Create CODEOWNERS

Actually allow me to do checks  properly

* Add Contribution Tutorial (#12)

* Add Contribution Tutorial

* Update CONTRIBUTING.md

* Added some logos (#22)

Co-authored-by: Skylar Gray <[email protected]>

---------

Co-authored-by: Reggie Torres <[email protected]>
Co-authored-by: Skylar Gray <[email protected]>
Co-authored-by: Skylar Gray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants