feat: OAtuh / Security Logic 코드리뷰 반영 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-beeen
commented
Mar 17, 2024
Comment on lines
51
to
52
| return memberRepository.findByProviderIdAndProviderType(kakaoProviderId, providerType) | ||
| ?: memberRepository.save(Member(kakaoProviderId, providerType, Role.ROLE_TEMP_USER)) |
h-beeen
commented
Mar 17, 2024
| @@ -1,5 +1,5 @@ | |||
| package com.vacgom.backend.application.auth.dto | |||
|
|
|||
| data class KakaoMemberResponse( | |||
| data class ResourceIdResponse( | |||
There was a problem hiding this comment.
이 부분은 나중에 인터페이스로 추상화해도 좋을 것 같아요.
다만 아직 공통 프로퍼티에 대한 정보가 없어 추상화까지는 필요 없다고 생각했어요.
h-beeen
commented
Mar 18, 2024
Comment on lines
+15
to
+18
| fun securityTest(@AuthId id: UUID): ResponseEntity<String> { | ||
| println("UUID/ id = ${id}") | ||
| return ResponseEntity.ok("success!!") | ||
| } |
There was a problem hiding this comment.
User ID 이런식으로 활용하시면 됩니다.
h-beeen
changed the title
|
선머지 후리뷰 예정 |
h-beeen
added a commit
that referenced
this pull request
Mar 18, 2024
* feat: Member Entity 필요 속성 추가 * feat: Configuration 계층 수정 * feat: Init Kakao Oauth / Redirect API * feat: OAuth2 Provider 기준 분기 후 로그인 API로 Redirect * feat: JWT 기본 로직 / ProviderId 기반 회원가입/로그인 로직 * chore: 패키지 구조 개선 * feat: JWT 연동 완료 및 구조 개선 * feat: OAtuh / Security Logic 코드리뷰 반영 (#8) * feat: JWT 연동 완료 및 구조 개선 * feat: OAuth2 구현 완료 * feat: 코틀린스러운 문법 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
🎋 Issue Ticket
🔑 주요 작업사항
🏞 (Optional) 참고 자료
(중요) 서브모듈이 수정되었나요?
꼭 확인해 주세요!!
feat/#1-1->feat/#1->develop순으로 머지 예정입니다.