SMBIOS support for HiKey #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements initial support for SMBIOS/DMI for the 96Boards HiKey Platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Brian McKenzie <[email protected]>
…robe type17 data * Add HiKey memory descriptor data to type19 table for free system memory. * Since the HiKey has shipped with at least 3 RAM chip variants, dynamically populate the type17 descriptor table with data from the DDR PHY.
* Dynamically set speed and size in smbios type17 table * Don't report more memory than we really have for type19 tables * Minor formatting changes and updated copyright
Dynamically generate type16 smbios descriptor table to accurately reflect the amount of physical memory on the board.
|
Could you help to show me the benefit to support SMBIOS on HiKey? |
vishalbhoj
force-pushed
the
hikey-aosp
branch
2 times, most recently
from
a1142af
to
f70886c
Compare
|
I have cherry-picked this into my repo for booting generic linux distros on the hikey. https://github.com/jlinton/OpenPlatformPkg Thanks, |
|
BTW: One of the reasons for adding SMBIOS to edk2, besides various things in linux that use the info, is that the EDK2 BDS displays the information in the menu header. |
|
How to verify the feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces basic SMBIOS/DMI support for the HiKey platform.
This driver is largely based off of the ARM Juno implementation, with the improvement of dynamically detecting RAM information for CircuitCo, Lemaker 1GB, and LeMaker 2GB variants of the HiKey board. I'm quite new to UEFI development, so any suggestions for improvements are very much welcome.