Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added textCommand #181

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

mbalduccini
Copy link

Added textCommand -- see https://github.com/thorsten-gehrig/alexa-remote-control. Version bumped to 3.10.5.

More changes related to textCommand extension
More changes related to textCommand extension
More changes related to textCommand extension
Details added
@ammawel
Copy link

ammawel commented Dec 29, 2020

Hey, thanks for continuing to develop the Node!
How about upgrading the alexa-remote dependency to version 3.5.0 (https://github.com/Apollon77/alexa-remote) and using the textCommand function integrated there as all other functions do?
Then all commands would be included in the dependency; it would be easier if amazon changes something.
Thank you, Achim

@mbalduccini
Copy link
Author

Hi! It would be good, but as far as I can tell none of the other commands from alexa-remote-routine.js is implemented using alexa-remote. Wouldn't switching everything require an almost complete rewrite of alexa-remote-routine.js? Or did I misunderstand your suggestion?

Best,
Marcello

@ammawel
Copy link

ammawel commented Jan 3, 2021

Hi Marcello! The dependency alexa-remote is used after all.
A big problem with contrib-Alexa-remote2 is that the speak-command no longer works at some point - all other commands still work. (node-red-forum, issues on github i.e., or here ) No error message is given until version 3.5.0 of the dependency. Only with the new 3.5.0 there is a null object in case of an error (Alexa says nothing) returned, otherwise "suucess: true" is delivered as result. So the code of the dependency is obviously used.
But the next problem is that the node-red module seems to be no longer maintained; the only maintainer 586837r has not been active since July and does not answer questions or error messages. I'm afraid he won't answer your pull-request either ;-)
Actually, contrib-Alexa-remote2 is not usable in its current form, especially if Amazon changes something.
Unfortunately, there doesn't seem to be an alternative for this modul in node-red either.

Best regards,
Achim

@MattL0
Copy link

MattL0 commented Jan 6, 2021

Maybe it’s time to fork this repo. And update https://github.com/Apollon77/alexa-remote

dependency

@bbindreiter
Copy link

Hi @mbalduccini. I have forked this node (https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel) and would like to incorporate your PR.

Can you rebase and create a PR in my repo? If not, are you ok with me adding your code (with full attribution of course)?

Thanks

@mbalduccini
Copy link
Author

Hi @mbalduccini. I have forked this node (https://github.com/bbindreiter/node-red-contrib-alexa-remote2-applestrudel) and would like to incorporate your PR.

Can you rebase and create a PR in my repo? If not, are you ok with me adding your code (with full attribution of course)?

Thanks

If you'd like to point me to the steps needed for rebasing and creating a PR in your repo, I'll be happy to do it. Otherwise, it's also ok with me if you go ahead and add my code.

@bbindreiter
Copy link

Thanks @mbalduccini. I've added your code changes here: bbindreiter@ab48b11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants