Merge from GoogleCloudPlatform #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luca Prete <[email protected]>
* Update FAST logging * Fix readme * Fix tests
- This fix allows a GKE Standard cluster to be configured with no auto-provisioned node pool, but allow setting autocluster profile for user-provisioned node pools like created via `gke-nodepool` module. Co-authored-by: Julio Castillo <[email protected]>
…2244) * Removed bfd settings from net-vpn-ha as it is not supported * Removed bfd settings from net-vpn-ha as it is not supported
Co-authored-by: Ludovico Magnocavallo <[email protected]>
…ectories (#2247) Co-authored-by: Ludovico Magnocavallo <[email protected]>
* Misc FAST fixes * Fix readme * Fix FAST nva bgp tests
* remove data source from folder module * fix fast tfdoc * fix locals type error * fix folder test * fix fast test
* Updates to support hybid NAT * Fix readme * Fix variable order
`local.folders` is just a map of var-based keys to string manipulations on those keys, while `local.hierarchy` is the seemingly-intended map of var-based keys to generated IDs/numbers. see https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/project-factory/factory-folders.tf#L32 vs. https://github.com/GoogleCloudPlatform/cloud-foundation-fabric/blob/master/modules/project-factory/factory-folders.tf#L39 Thank you for recently developing this convenient module!
* Add PSC endpoints consumers to net-address * Cloud SQL E2E tests
…als (#2267) * Fix 0-bootstrap iam_by_principals not taking into account all principals * Add test-case for iam_by_principals for 0-bootstrap stage --------- Co-authored-by: Ludovico Magnocavallo <[email protected]>
* IAM authoritative bindings in org module * remove extra newline * organization module * project module * tfdoc
* new bindplane cloud-config-container setup
* Added support to kms key * Updated doc * Fix variable description. * Updated README * Cloud function v2 integration with kms * Fix variables description --------- Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge from GoogleCloudPlatform