Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added numpy ^1.26.4 in pyproject.toml #312

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Conversation

dmichaels-harvard
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9892464224

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 75.67%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dcicutils/hack_for_elasticsearch_numpy_usage.py 4 5 80.0%
dcicutils/snapshot_utils.py 0 1 0.0%
Totals Coverage Status
Change from base Build 9759169032: -0.001%
Covered Lines: 11374
Relevant Lines: 15031

💛 - Coveralls

"schema_version"
]

_SCHEMA_ORDER = [ # See: smaht-portal/src/encoded/project/loadxl.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you use this for? I would recommend not doing it this way, instead add an API in smaht-portal that returns this and have this info come in via a call to the server

@dmichaels-harvard dmichaels-harvard merged commit 6b05b66 into master Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants