Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More schema parsing #309

Merged
merged 7 commits into from
Jun 12, 2024
Merged

More schema parsing #309

merged 7 commits into from
Jun 12, 2024

Conversation

drio18
Copy link
Contributor

@drio18 drio18 commented Jun 10, 2024 •
edited
Loading

This PR adds schema parsing functions for existing properties as well as some new ones that are useful for providing more context to submitters, such as examples outside of (suggested) enums and comments specifically intended for the submission templates.

Related PRs:

@coveralls
Copy link

coveralls commented Jun 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9455934465

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.995%
Totals Coverage Status
Change from base Build 9277005856: 0.02%
Covered Lines: 11321
Relevant Lines: 14897
💛 - Coveralls

@drio18 drio18 mentioned this pull request Jun 11, 2024
Merged
@drio18 drio18 requested review from aschroed and willronchetti June 11, 2024 14:17
aschroed
aschroed approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@aschroed aschroed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9484652757

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 75.681%
Totals Coverage Status
Change from base Build 9467512300: 0.02%
Covered Lines: 11365
Relevant Lines: 15017
💛 - Coveralls

@drio18 drio18 merged commit 538acd0 into master Jun 12, 2024
4 checks passed
@drio18 drio18 deleted the drr_schema_fields branch June 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willronchetti willronchetti willronchetti approved these changes

@aschroed aschroed aschroed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drio18 @coveralls @aschroed @willronchetti