SMaHT ingestion work. Moved structured_data.py from smaht-portal to here. (Tests still in smaht-portal though for now). #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handle sub-class refs.
…e_map to handle sub-class refs.
…e_map to handle sub-class refs.
…e_map to handle sub-class refs.
…e_map to handle sub-class refs.
…e_map to handle sub-class refs.
Pull Request Test Coverage Report for Build 7173036488
💛 - Coveralls |
willronchetti
approved these changes
Dec 6, 2023
dcicutils/misc_utils.py
Outdated
| @@ -1501,6 +1501,14 @@ def right_trim(list_or_tuple: Union[List[Any], Tuple[Any]], | |||
| return list_or_tuple[:i + 1] | |||
|
|
|||
|
|
|||
| def create_object(**kwargs) -> dict: | |||
There was a problem hiding this comment.
object is a synonym in some sense but I'd maybe prefer create_dict?
Comment on lines
+62
to
+65
| def load(file: str, portal: Optional[Union[VirtualApp, TestApp, Portal]] = None, | ||
| schemas: Optional[List[dict]] = None, | ||
| order: Optional[List[str]] = None, prune: bool = True) -> StructuredDataSet: | ||
| return StructuredDataSet(file=file, portal=portal, schemas=schemas, order=order, prune=prune) |
There was a problem hiding this comment.
Some docstring may be useful especially in situations where you have a lot of complex/mixed types as input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.