SMaHT ingestion related work. #293
Conversation
Pull Request Test Coverage Report for Build 7045798624Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
| def unpack_zip_file_to_temporary_directory(file: str) -> str: | ||
| with temporary_directory() as tmp_directory_name: | ||
| with zipfile.ZipFile(file, "r") as zipf: | ||
| zipf.extractall(tmp_directory_name) | ||
| yield tmp_directory_name | ||
|
|
||
|
|
||
| @contextmanager | ||
| def unpack_tar_file_to_temporary_directory(file: str) -> str: | ||
| with temporary_directory() as tmp_directory_name: | ||
| with tarfile.open(file, "r") as tarf: | ||
| tarf.extractall(tmp_directory_name) | ||
| yield tmp_directory_name | ||
|
|
There was a problem hiding this comment.
You might want to allow optional args to these functions in case additional options are needed/desired
| with tempfile.TemporaryDirectory() as tmp_directory_name: | ||
| yield tmp_directory_name | ||
| finally: | ||
| remove_temporary_directory(tmp_directory_name) |
There was a problem hiding this comment.
I thought temp directories were removed automatically?
There was a problem hiding this comment.
Oh yeah, wait a minute, I think you should be right; I think I did this for a reason, need to remind myself.
| def __init__(self): | ||
| super().__init__() |
There was a problem hiding this comment.
Is this not the default behavior?
There was a problem hiding this comment.
No it's not. A derived init must explicitly call its base init, if it wants that behavior.
| found = True | ||
| for item in item_ref: | ||
| if not lookup_table.get(item): | ||
| found = False | ||
| break | ||
| return True if found else None |
There was a problem hiding this comment.
Why mixed return value (None + bool, why not just bool). Also, why not just
for item in item_ref:
if not lookup_table.get(item):
return None
return True
| found = True | ||
| for item in item_ref: | ||
| info = get_metadata(f"/{to_camel_case(item_type)}/{item}", | ||
| ff_env=self.portal_env, vapp=self.portal_vapp) | ||
| if not isinstance(info, dict) or 'uuid' not in info: | ||
| found = False | ||
| break |
There was a problem hiding this comment.
Same pattern here as above can be simplified
No description provided.