-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 upgrade #279
Merged
Merged
Python 3.11 upgrade #279
Changes from 2 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7e142b1
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard ece924a
Up pyyaml version to ^6.0.1 for Mac M1 issue with build.
dmichaels-harvard 4a8f051
CHANGELOG changes.
dmichaels-harvard 2e99cf7
Merge from master
dmichaels-harvard 2f49bcb
version update
dmichaels-harvard 829e5b0
Fix to test_s3_utils from kmp_sheet_utils_schema_hinting branch.
dmichaels-harvard 53c8e6d
flake8 update
dmichaels-harvard 69093fa
Merge from master
dmichaels-harvard 6cc26bc
Update to Python 3.11!
dmichaels-harvard abe2140
Update to Python 3.11!
dmichaels-harvard a7fa068
Update boto3/botocore versions.
dmichaels-harvard 669e51f
Update boto3/botocore versions.
dmichaels-harvard 4b70bd2
CHANGELOG comments
dmichaels-harvard 927862e
Update to Python 3.11
dmichaels-harvard 702aedb
Remove Python 3.7 from pyproject and GA
dmichaels-harvard 5b4c84b
Updated pip-licenses
dmichaels-harvard 4120faa
Updated pip-licenses
dmichaels-harvard a25959b
update python to 3.9 in static-checks.yml
dmichaels-harvard 07bbdd0
Removed pip from pyproject
dmichaels-harvard ba13cbf
Put pytest to latest version and added pytest-redis to ^3.0.2.
dmichaels-harvard 7ed1511
Update version
dmichaels-harvard 88f3b89
Updated boto versions.
dmichaels-harvard 3e5cf5f
Updated boto versions.
dmichaels-harvard e24b3e0
Added Python 3.10, 3.11 to pyproject Python list
dmichaels-harvard c760707
Update Ubuntu to 22.04 for GA
dmichaels-harvard 7b3daaf
Update Ubuntu to 22.04 for GA and poetry update
dmichaels-harvard 099a32e
back out ubuntu to 22.04 for now to test - ga failing all of a sudden
dmichaels-harvard 25a4b58
put back update to ubuntu 20.04 -> 22.04 for ga and see if ga fails now
dmichaels-harvard 96cc528
ga failed with ubuntu 22.04 for python 3.11 - put back 20.04 to make …
dmichaels-harvard 97f1173
put ubuntu 22.04 back for ga and add testing hack in qa_utils.py
dmichaels-harvard b226d61
flake8 error
dmichaels-harvard 45064b2
more hacking of qa_utils for troubleshooting ga failure with ubuntu 2…
dmichaels-harvard bd6a797
Updated comments
dmichaels-harvard 96a10cb
Fix to qa_utils for application/vnd.software602.filler.form+xml mime …
dmichaels-harvard af72ea9
Merged in master
dmichaels-harvard f7c05b5
poetry update
dmichaels-harvard 27e11b6
Bumped to Python 3.11 in static-checks.yml
dmichaels-harvard 2699a4d
Update version to 8.0.0; ready to merge to master.
dmichaels-harvard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a major version 8.0.0 would be wise, so that if there's an issue, it's easy for someone to use
^7.x.kinds of notation to select stuff that doesn't have this until a fix is ready. Probably not an issue, but that thing about change in required arg worries me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willronchetti do you have an opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried about that required arg. I note that if you search for calls to yaml.load in 4dn-dcic (which is only one of our 3 orgs), you'll see several calls that don't pass an explicit Loader argument. Will that work or are you forcing code updates? Maybe those updates are fine. If there is an obvious loader, maybe we should have something that someone can call instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looking at those results as well as for dbmi-bgm and smaht-dac, I don't see any uses within a repo where dcicutils is used (where the version of pyyaml it uses will increments due to this dcicutils change). The only affected repos are cwltools and parliament2 - neither of which has any reference to dcicutils anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built a cgap-portal(branch: dcicutils-with-pyyaml-6-and-sheet-utils | version: 14.2.0.1b1) with this dcicutils/pyyaml update and deployed to cgap-supertest and it seems fine (login/logout, create access-key, and ran submit-metadata-bundle).