[DSC-472] Empty contextual menu

4Science · Mar 4, 2022 · c3f78de · c3f78de
1 parent 7194349
commit c3f78de
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/src/app/shared/context-menu/context-menu.component.html b/src/app/shared/context-menu/context-menu.component.html
@@ -2,7 +2,8 @@
   <ng-container *ngFor="let entry of (getStandAloneMenuEntries() | async)">
     <ng-container *ngComponentOutlet="entry; injector: objectInjector;"></ng-container>
   </ng-container>
-  <div ngbDropdown #itemOptions="ngbDropdown" placement="bottom-right" class="d-inline-block float-right ml-1">
+  <div ngbDropdown #itemOptions="ngbDropdown" placement="bottom-right"
+       class="float-right ml-1" [ngClass]="optionCount === 0 ? 'd-none' : 'd-inline-block'">
     <button class="btn btn-outline-primary" id="context-menu" ngbDropdownToggle>
       <i class="fas fa-ellipsis-h" aria-hidden="true"></i>
     </button>
@@ -11,9 +12,6 @@ <h6 class="dropdown-header">{{'context-menu.actions.label' | translate}}</h6>
       <ng-container *ngFor="let entry of (getContextMenuEntries() | async)">
         <ng-container *ngComponentOutlet="entry; injector: objectInjector;"></ng-container>
       </ng-container>
-      <label class="dropdown-item" *ngIf="optionCount === 0">
-        {{'context-menu.actions.no-options-available' | translate}}
-      </label>
     </div>
   </div>
 

diff --git a/src/app/shared/context-menu/context-menu.component.ts b/src/app/shared/context-menu/context-menu.component.ts
@@ -133,10 +133,12 @@ export class ContextMenuComponent implements OnInit {
 
   ngAfterViewChecked() {
     // To check that Context-menu contains options or not
-    const el = Array.from(document.getElementById('itemOptionsDropdownMenu').getElementsByClassName('ng-star-inserted'));
+    const el = Array.from(document.getElementById('itemOptionsDropdownMenu')?.getElementsByClassName('ng-star-inserted'));
     this.optionCount = 0;
-    el.forEach(element => {
-      this.optionCount += element.childElementCount;
-    });
+    if (el) {
+      el.forEach(element => {
+        this.optionCount += element.childElementCount;
+      });
+    }
   }
 }
diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5
@@ -1415,8 +1415,6 @@
 
   "context-menu.actions.label": "Options",
 
-  "context-menu.actions.no-options-available": "No Options Available",
-
   "context-menu.actions.edit-item.btn.FULL": "Edit all the details",
 
   "context-menu.actions.edit-item.btn.OWNER": "Edit",