forked from DSpace/DSpace
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push selected publications to orcid #351
Open
floriangantner
wants to merge
25
commits into
4Science:dspace-cris-2023_02_x
Choose a base branch
from
uniba-ub:dspace-cris-7-orcid-relpref
base: dspace-cris-2023_02_x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Push selected publications to orcid #351
floriangantner
wants to merge
25
commits into
4Science:dspace-cris-2023_02_x
from
uniba-ub:dspace-cris-7-orcid-relpref
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the orcid profiles owner with OrcidEntitySyncPreference MINE and MY_SELECTED for some entity an additional check was added. The check uses the solr-search to determine, if the corresponding/linked item is among the hidden/preferred items of the orcid profile owner. The solr query for the relation can be configured.
for the orcid profiles owner with OrcidEntitySyncPreference MINE and MY_SELECTED for some entity an additional check was added. The check uses the solr-search to determine, if the corresponding/linked item is among the hidden/preferred items of the orcid profile owner. The solr query for the relation can be configured.
…o dspace-cris-7-orcid-relpref # Conflicts: # dspace-api/src/main/java/org/dspace/orcid/consumer/OrcidQueueConsumer.java
…ings sync settings
…and fundings sync settings" This reverts commit d4861ec.
8 tasks
this can occur when some relation was removed (e.g. selected) which is not reflected to the orcid queue. The entry is only removen when the whole queue is recalculated
especially new introduced null checks
tests to check the creation of OrcidEntitySyncPreference MINE and MY_SELECTED with different configuration settings and test cases as well as new tests on changes on the recalculation of the orcid queue with these new settings
floriangantner
changed the title
WIP: Push selected orcid works
Push selected orcid works
Aug 18, 2023
floriangantner
changed the title
Push selected orcid works
Push selected publications to orcid
Aug 18, 2023
use database-approach instead of solr because the values might not be indexed/remodev when the orcidconsumer interacts; simplify configuration to name of relationship instead of filter; some fixes and tests
check if relationship exist using the relationshipservice rather than the search, becaude the requested item might not have been indexed yet if it is recent archived
[maven-release-plugin] copy for tag dspace-cris-2023.02.02
Aligned to 2023.02.02 Release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Push SELECTED (MY_SELECTED) and not hidden (MINE) Publications settings to some person orcid profile. The items are determined through the regarding relationshiptypes which allows the user to hide/show the publications on certain relation boxes.
Instructions for Reviewers
List of changes in this PR:
Some additional
.exclusion
configuration is used when the relation should not exist (e.g. show not publications which are hidden) and adds some negation to the solr filter/check for the relations.isAlreadyQueued
. Some new method was introduced which uses the relationshipService to determine, if the relation was removed/added and the orcid sync settings (MINE/MY_SELECTED) are not in sync. In this cases the orcidqueue entry is deleted.Include guidance for how to test or review your PR.
Counterpart:
4Science/dspace-angular#38
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
pom.xml
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.