make accessToken an io to use gh app's expiring tokens #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
===========================================
- Coverage 91.47% 74.17% -17.30%
===========================================
Files 24 25 +1
Lines 657 608 -49
Branches 2 2
===========================================
- Hits 601 451 -150
- Misses 56 157 +101
Continue to review full report at Codecov.
|
This reverts commit 0845bc9
making it a function so that GithubApp implementation could catch an expired token exception
BenFradet
reviewed
Nov 10, 2020
| /** | ||
| * Source of static or expiring github tokens | ||
| */ | ||
| trait AccessTokens[F[_]] { |
There was a problem hiding this comment.
Suggested change
| trait AccessTokens[F[_]] { | |
| trait AccessToken[F[_]] { |
| def withAccessToken[T](f: Option[String] => F[GHResponse[T]]): F[GHResponse[T]] | ||
| } | ||
|
|
||
| object AccessTokens {} |
There was a problem hiding this comment.
Suggested change
| object AccessTokens {} |
| /** | ||
| * A simple static version | ||
| */ | ||
| class StaticAccessTokens[F[_]](accessToken: Option[String]) extends AccessTokens[F] { |
There was a problem hiding this comment.
Suggested change
| class StaticAccessTokens[F[_]](accessToken: Option[String]) extends AccessTokens[F] { | |
| class StaticAccessToken[F[_]](accessToken: Option[String]) extends AccessToken[F] { |
* add doc
|
I've renamed AccessTkoens and added some docs, my english might not be perfect though. I tried running integrations tests locally with my personal token, and some of the tests fail for an obvious reason (me not having enough permissions for the github4s repository). Others are fine. |
BenFradet
reviewed
Nov 16, 2020
|
|
||
| object GithubAPIv3 { | ||
|
|
||
| def noAuth[F[_]: Sync](client: Client[F], config: GithubConfig) = |
Co-authored-by: Ben Fradet <[email protected]>
BenFradet
approved these changes
Nov 17, 2020
juanpedromoreno
approved these changes
Nov 17, 2020
juanpedromoreno
added
the
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. In my project I want to use Github App auth, which operates expiring tokens. So here is a proposed change to the insides of the api:
The default Github constructor stays the same, it's accessToken is just wrapped into a pure version of AccessTokens.
I've read you don't want to bring things like jwt on board, so the implementation of AccessTokens for apps is left for users.