Merge pull request #817 from nicoulaj/fix-assert

fix test assert returning success in case of decoding error
47degrees · Sep 15, 2022 · 5002bf5 · 5002bf5
2 parents b2aa183 + 30d65d7
commit 5002bf5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/github4s/shared/src/test/scala/github4s/utils/BaseIntegrationSpec.scala b/github4s/shared/src/test/scala/github4s/utils/BaseIntegrationSpec.scala
@@ -65,8 +65,9 @@ abstract class BaseIntegrationSpec
 
   def testIsRight[A](response: GHResponse[A], f: A => Assertion = (_: A) => succeed): Assertion = {
     withClue(response.result) {
-      response.result.toOption map (f(_)) match {
-        case _ => succeed
+      response.result match {
+        case Left(error)  => fail(error.getMessage())
+        case Right(value) => f(value)
       }
     }
   }