Fix Dockerfile python version and dependencies installation (#500)

42School · Jun 20, 2024 · da368aa · da368aa
1 parent a9e1a3d
commit da368aa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,11 +1,16 @@
-FROM python:3.7-alpine
+FROM python:3.12-alpine
 
 WORKDIR /usr/src/norminette
 
+COPY pyproject.toml poetry.lock ./
+
+RUN pip3 install poetry \
+    && poetry config virtualenvs.create false \
+    && poetry install --no-dev
+
 COPY . .
 
-RUN pip3 install -r requirements.txt \
-	&& python3 setup.py install
+RUN python3 setup.py install
 
 WORKDIR /code
 

diff --git a/README.md b/README.md
@@ -67,13 +67,13 @@ norminette -dd
 ```
 docker build -t norminette .
 cd ~/42/ft_printf
-docker run -v $PWD:/code norminette /code
+docker run --rm -v $PWD:/code norminette
 ```
 
 If you encounter an error or an incorrect output, you can:
- - Open an issue on github 
+ - Open an issue on github
  - Post a message on the dedicated slack channel (#norminette-v3-beta)
-    
+
 
 Please try to include as much information as possible (the file on which it crashed, etc)