-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mlx_new_fullscreen_window. #45
base: master
Are you sure you want to change the base?
Conversation
Hi ! EDIT : Ah no, I do not have that in my function, you added that by your own, mb. It is still not pretty 👀 |
I think it will be much better not to duplicate whole 50-lines function with differences in 2 lines, but make it much shorter with only 3 steps:
|
Will do. |
@Rush-iam it's segfaulting when I call |
@Rush-iam I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥 🔥
This is really useful if someone is using mlx with a tiling window manager
I would like to add this functions that lets you create a fullscreen window.
I wanna add a fullscreen mode to my fract-ol project.
It's almost identical to
mlx_new_window
, except it gets the screen resolution frommlx_get_screen_size
and sets theoverride_redirect
WindowAttribute totrue
.It's based on @jerem-ma 's implementation:
I don't know if there's a better way of doing this, and I'm open to suggestions.
I also separated the test main into different functions to facilitate debugging.
Thank you for your time.