-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dasharo Product Naming Convention - Pro Package change #158
Open
Stanislaw-bnk
wants to merge
1
commit into
develop
Choose a base branch
from
DES-naming-convention
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stanislaw-bnk do you plan to change the shop product names (WP) and URL product name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artur-rs Product names in the shop have been changed. I will update the URLs only if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stanislaw-bnk and make sure to create correct redirections from old URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artur-rs As for now we will not change the URLs in the online shop.
@pietrushnic This point is only mentioned in the
Dasharo Package for Network Appliance
:But the above description is not precise, as ENTERPRISE is for personal use above 5 units OR for companies from the first unit. We should modify this in the description, mention this to the Dasharo Pro Package for Desktop and add it to the Dasharo Terms of Service @gosiastyba cc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stanislaw-bnk I'm not sure I understand, can you propose a change in Pull Request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, the details distinguishing the PRO and ENTERPRISE Packages are currently only provided in the online shop for the following two products:
Dasharo (coreboot+UEFI) Pro Package for Network Appliance
Dasharo (coreboot+SeaBIOS) Pro Package for Network Appliance
However, this information is missing from the Dasharo (coreboot+UEFI) Pro Package for Desktop.
We should add this for clarification and expand the description to specify that the ENTERPRISE is for personal use above 5 units but ALSO for companies from the first unit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key question is why ToS is not updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pietrushnic I have created a new Issue regarding the ToS: Dasharo/dasharo-website#71 @gosiastyba cc