Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement for 3 7 #3984

Merged
merged 5 commits into from
Nov 30, 2023
Merged

UI improvement for 3 7 #3984

merged 5 commits into from
Nov 30, 2023

Conversation

mdouchin
Copy link
Collaborator

@mdouchin mdouchin commented Nov 24, 2023

  • User interface - Implement a brand-new default theme
    • Backgrounds are light and not dark any more
    • Buttons are flat
    • Tabs for editing form and "Dataviz" charts are more discrete (only underline active tab with thick blue)
    • Popup tables header have dark background
    • Use CSS variables to help user change the colours
    :root {
      --header-color: #43718c;
      /* --header-background-image: url(img/header-background-medium.jpg); */
      --header-background-image: none;
      --color-background-primary: #ffffffdb;
      --color-background-primary-content: #ffffffdb;
      --color-text-primary: rgb(51, 51, 51);
      --color-text-primary-content: rgb(51, 51, 51);
      --color-contrasted-elements: #43718c;
      --color-contrasted-elements-light: #c3dceb;
      --color-contrasted-text: white;
      --color-dark-gray-elements: rgb(51, 51, 51);
      --color-red-elements: #da4f49;
    }
  • Editing - Prevent the user to close the windows if an editing session is active
  • Attribute table - Allow to display the popup of non-spatial features with the (i) button

Funded by 3liz, Ville d'Avignon

Some screenshots

  • Before
    image

  • After
    image

@mdouchin mdouchin self-assigned this Nov 24, 2023
@github-actions github-actions bot added this to the 3.8.0 milestone Nov 24, 2023
@mdouchin mdouchin modified the milestones: 3.8.0, 3.7.0 Nov 24, 2023
@rldhont rldhont added user interface run end2end If the PR must run end2end tests or not labels Nov 24, 2023
@Gustry
Copy link
Member

Gustry commented Nov 27, 2023

In bot, you can trust the milestone ;-)

@Gustry Gustry modified the milestones: 3.7.0, 3.8.0 Nov 27, 2023
@mdouchin mdouchin marked this pull request as ready for review November 28, 2023 17:20
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks !
LGTM

Kind of related request, feel free to skip, would it be possible to have lizmap/www/themes/default/css/main.css and lizmap/www/themes/default/css/map.css in the JSON metadata in order to avoid the gray theme from Bootstrap in 3liz/lizmap-plugin#525 ? (including the boostrap one ?) otherwise, in the meantime, I can hardcode them.

@Gustry
Copy link
Member

Gustry commented Nov 30, 2023

The list of CSS has been hardcoded : 3liz/lizmap-plugin#532

@rldhont rldhont merged commit abc431e into 3liz:master Nov 30, 2023
9 checks passed
@nboisteault
Copy link
Member

@mdouchin logo.png size is now 1275x1275, before it was 60x60. Is it used elsewhere where it needs this size? In this case we need several image size.

@mdouchin
Copy link
Collaborator Author

@mdouchin logo.png size is now 1275x1275, before it was 60x60. Is it used elsewhere where it needs this size? In this case we need several image size.

I will fix it, thanks !

@mdouchin mdouchin deleted the ui_improvement_for_3_7 branch November 30, 2023 11:15
@mdouchin
Copy link
Collaborator Author

@mdouchin logo.png size is now 1275x1275, before it was 60x60. Is it used elsewhere where it needs this size? In this case we need several image size.

I will fix it, thanks !

done and backported b17bcc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3_7 run end2end If the PR must run end2end tests or not user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants