-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update aframe-loader-3dtiles-component: fix load errors #663
Conversation
Is this 3DStreet/aframe-loader-3dtiles-component#9 ? This PR should really be on the board in the review column. |
yes, you right. Otherwise it gets confusing. I will remove PRs in 3DStreet |
Closed, because already have this PR: 3DStreet/aframe-loader-3dtiles-component#9 |
Yeah but you need to copy the file in 3dstreet repository, so you still need this PR. |
|
@Algorush I will wait to merge this until you can confirm that the https://github.com/3DStreet/aframe-loader-3dtiles-component/ repo is actually up-to-date with what is intended to be in the 3dstreet repo |
Updated lib to the last version in last commit |
Added check for
this.viewportSize
to theTick
function inaframe-loader-3dtiles-component.js
to prevent error with undefined value described in this issue: #633Also same issue: #661