Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aframe-loader-3dtiles-component: fix load errors #663

Merged
merged 6 commits into from
Jun 23, 2024

Conversation

Algorush
Copy link
Collaborator

@Algorush Algorush commented Jun 20, 2024

Added check for this.viewportSize to the Tick function in aframe-loader-3dtiles-component.js to prevent error with undefined value described in this issue: #633
Also same issue: #661

@vincentfretin
Copy link
Collaborator

Is this 3DStreet/aframe-loader-3dtiles-component#9 ? This PR should really be on the board in the review column.
Does the other PRs in https://github.com/3DStreet/aframe-loader-3dtiles-component/pulls also in the build? If yes those should be merged there.

@Algorush
Copy link
Collaborator Author

This PR should really be on the board in the review column.

yes, you right. Otherwise it gets confusing. I will remove PRs in 3DStreet

@Algorush
Copy link
Collaborator Author

Closed, because already have this PR: 3DStreet/aframe-loader-3dtiles-component#9

@Algorush Algorush closed this Jun 21, 2024
@vincentfretin
Copy link
Collaborator

Yeah but you need to copy the file in 3dstreet repository, so you still need this PR.

@Algorush Algorush changed the title fix tick function in loader-3dtiles component update aframe-loader-3dtiles-component: fix load errors Jun 21, 2024
@Algorush Algorush reopened this Jun 21, 2024
@kfarr
Copy link
Collaborator

kfarr commented Jun 21, 2024

Do we need both the minified and unminified versions here?
nevermind, I removed the unminified file and files that used them

@kfarr
Copy link
Collaborator

kfarr commented Jun 21, 2024

@Algorush I will wait to merge this until you can confirm that the https://github.com/3DStreet/aframe-loader-3dtiles-component/ repo is actually up-to-date with what is intended to be in the 3dstreet repo

@Algorush
Copy link
Collaborator Author

Updated lib to the last version in last commit

@kfarr kfarr merged commit 3d23463 into main Jun 23, 2024
1 check passed
@kfarr kfarr deleted the 3dtiles-fix-error branch June 23, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants