Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panels disappearing when selecting a-videosphere entity #623

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

vincentfretin
Copy link
Collaborator

backport changes from aframevr/aframe-inspector#680
This probably may not be an issue in 3dstreet because you don't use video texture yet, but who knows in the future you may so better to backport all the fixes I did in aframe-inspector.

Note in this part of the code you had a change where you added a condition line 155 in new code, I kept it.

      if (typeof value === 'string') {
        url = AFRAME.utils.srcLoader.parseUrl(value);
      }

@kfarr kfarr merged commit be3c9d8 into main Jun 12, 2024
1 check passed
@kfarr kfarr deleted the videosphere-fix branch June 12, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants