Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update the UI when adding or removing a mixin #620

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Algorush
Copy link
Collaborator

@Algorush Algorush commented Jun 11, 2024

From this list: #519 (comment)
moved from aframe-inspector repository: aframevr/aframe-inspector#699
Now UI is still not updating with the mixin name at the top of the right panel when you update a mixin, only after close/open right panel. But UI updating in the left panel.

@vincentfretin
Copy link
Collaborator

Ok good.
In aframe-inspector, the entity representation is in CommonComponents, but in 3dstreet it's hidden with css and the title is really in Sidebar. I fixed it.

@kfarr kfarr merged commit 89443e5 into main Jun 12, 2024
1 check passed
@kfarr kfarr deleted the update-ui-add-remove-mixin branch June 12, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants