Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression of exporting vec2 and vec3 like rotation (fix #534) #548

Merged
merged 1 commit into from
May 31, 2024

Conversation

vincentfretin
Copy link
Collaborator

Regression from fixing lint errors in #530
This closes #534

Copy link

netlify bot commented May 31, 2024

Deploy Preview for 3dstreet-core-builds ready!

Name Link
🔨 Latest commit 5113c08
🔍 Latest deploy log https://app.netlify.com/sites/3dstreet-core-builds/deploys/6659ecc35294f20008c32b6d
😎 Deploy Preview https://deploy-preview-548--3dstreet-core-builds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincentfretin vincentfretin changed the title Fix regression of exporting vec2 and vec3 lie rotation (fix #534) Fix regression of exporting vec2 and vec3 like rotation (fix #534) May 31, 2024
@vincentfretin
Copy link
Collaborator Author

propData['x'] returned potentially 0 so that's false
propData.hasOwnProperty('x') returns true

@kfarr kfarr merged commit d5b6b4e into main May 31, 2024
5 checks passed
@kfarr kfarr deleted the fix-export-issue branch May 31, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The saved JSON scene is not loading correctly
2 participants